Small eslint config cleanup, use strict and stylistic lints #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meow
pushed a commit
that referenced
this pull request
May 12, 2025
* Enable `noImplicitOverride` in `tsconfig` * Remove some unnecessary disabled lints in tests * Fix unused vars * Disallow if-like && / || expression statements * Simplify config * Enable strict and stylistic lints * Add js eslint recommended configs * Remove unnecessary globs * Fix grammar
MareStare
added a commit
to MareStare/philomena
that referenced
this pull request
May 20, 2025
…a-dev#566) * Enable `noImplicitOverride` in `tsconfig` * Remove some unnecessary disabled lints in tests * Fix unused vars * Disallow if-like && / || expression statements * Simplify config * Enable strict and stylistic lints * Add js eslint recommended configs * Remove unnecessary globs * Fix grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you begin
My goal is to reduce the eslint config as much as possible plus enable lints that require type info (currently they trigger a lot of lints, so I haven't done this yet). This doesn't achieve that goal fully, but already removes some redundant configs from our
eslint.config.js.