-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add shellcheck
shell script files linter
#493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
. "$(dirname "${BASH_SOURCE[0]}")/lib.sh" | ||
|
||
TOOL_VERSION=${TOOL_VERSION:-1.31.1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we are now pinning the version of typos
, when previously we were using the master
version of typos
on CI. I think pinning the tool version is actually better in general, especially in case of typos
because typos
can produce new lints between patch releases. So every time typos
does a release it breaks Philomena's CI.
Instead, we should bump the version of typos
explicitly.
I... think this is going a tad too far with all the linting, considering you're adding this huge thing and this whole additional step, for the sake of files which we almost never modify. |
I can remove it from the precommit hook if its perf is concerning you, but I expect to extend the dev scripts over time. I don't think this linter costs anything. I specifically made it so that adding new linters is extremely easy in this PR by splitting the existing init.sh script into several files per each tool, otherwise the changes in this PR would be much smaller |
270d3bf
to
643f756
Compare
9d94e09
to
dcb474d
Compare
Superseded by #528 |
Before you begin
See the tool repo for details. Yeah it's written in Haskell