Skip to content

chore: echo proxy should not accept multiple requests #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: echo proxy should not accept multiple requests #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03bd378
chore: echo proxy should not accept another request while the previou…
EkelmansPh Aug 25, 2025
3ba1ae0
Merge branch 'main' into feature/echo_proxy_request_processing
EkelmansPh Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions protobuf/echo/Echo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "protobuf/echo/Echo.hpp"
#include "infra/util/ReallyAssert.hpp"

namespace services
{
Expand Down Expand Up @@ -35,13 +36,17 @@ namespace services

void ServiceProxy::RequestSend(infra::Function<void()> onGranted, uint32_t requestedSize)
{
really_assert(!inFlightRequest);
inFlightRequest = true;

this->onGranted = onGranted;
currentRequestedSize = requestedSize;
echo.RequestSend(*this);
}

infra::SharedPtr<MethodSerializer> ServiceProxy::GrantSend()
{
inFlightRequest = false;
onGranted();
return std::move(methodSerializer);
}
Expand Down
1 change: 1 addition & 0 deletions protobuf/echo/Echo.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ namespace services
infra::AutoResetFunction<void()> onGranted;
uint32_t currentRequestedSize = 0;
infra::SharedPtr<MethodSerializer> methodSerializer;
bool inFlightRequest = false;
};

class EchoPolicy
Expand Down
Loading