feat: adding new modes to gappairing for future enhancements in secureconnections #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issueslwip/lwip/CMakeLists.txt
external/args/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
osal/threadx/CMakeLists.txt
external/protobuf/CMakeLists.txt
osal/freertos/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
cmake/emil_test_helpers.cmake
infra/syntax/CMakeLists.txt
external/crypto/tiny-aes128/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.25s | |
| ✅ CPP | clang-format | 1028 | 8 | 0 | 0 | 6.84s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.37s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.16s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.6s |
| markdownlint | 6 | 0 | 4 | 0 | 1.16s | |
| markdown-link-check | 6 | 2 | 0 | 145.64s | ||
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.23s |
| ✅ REPOSITORY | checkov | yes | no | no | 19.88s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | no | 24.19s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.06s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 6.19s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.4s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.73s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.17s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.22s | |
| lychee | 138 | 2 | 0 | 9.94s | ||
| prettier | 22 | 1 | 1 | 0 | 0.81s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 4.38s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.54s |
See detailed report in MegaLinter reports
MiquelJayson-Philips
changed the title
MiquelJayson-Philips
changed the title
MiquelJayson-Philips
changed the title
MiquelJayson-Philips
requested review from
XavierBernhardt-Philips,
magi-arun and
oguzcanoguz
services/ble/Gap.hpp
Outdated
| }; | ||
|
|
||
| virtual void Pair() = 0; | ||
| // Values align with STM32 sdk ble core defs |
There was a problem hiding this comment.
I don't think we should align with a specific manufacturer. if for some reason the manufacturer has a different values, the class implement this interface should be responsible for adapting it.
oguzcanoguz
approved these changes
Jul 24, 2025
|
|
||
| virtual void Pair() = 0; | ||
| // Values align with STM32 sdk ble core defs | ||
| enum class SecureConnectionMode : uint8_t |
There was a problem hiding this comment.
I think we have the same three options for mitm and secureconnections:
notSupported,
supported,
enforced,
For some vendors, such as ST, we might not have the implementation for all combinations, which is fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of SecureConnectionMode and MitmMode values in GapPairing.
This is the first initiative for future enhancements in SC.