feat: improve pairing security requirements #884
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuescmake/emil_test_helpers.cmake
external/crypto/tiny-aes128/CMakeLists.txt
osal/threadx/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
lwip/lwip/CMakeLists.txt
external/args/CMakeLists.txt
external/protobuf/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
osal/freertos/CMakeLists.txt
infra/syntax/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.26s | |
| ✅ CPP | clang-format | 1028 | 8 | 0 | 0 | 6.74s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.38s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.17s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.62s |
| markdownlint | 6 | 0 | 4 | 0 | 1.14s | |
| markdown-link-check | 6 | 2 | 0 | 183.29s | ||
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.22s |
| ✅ REPOSITORY | checkov | yes | no | no | 20.51s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | no | 24.12s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.06s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 6.01s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.38s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.8s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.17s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 4.48s | |
| lychee | 138 | 2 | 0 | 8.08s | ||
| prettier | 22 | 1 | 1 | 0 | 0.79s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 6.19s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.58s |
See detailed report in MegaLinter reports
|
XavierBernhardt-Philips
changed the title
EkelmansPh
reviewed
Aug 5, 2025
Comment on lines
+145
to
+146
| virtual void | ||
| Pair() = 0; |
There was a problem hiding this comment.
Suggested change
| virtual void | |
| Pair() = 0; | |
| virtual void Pair() = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for secure ble pairing.
related to philips-software/amp-hal-st#573