PR test Altin #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Harden the broadcast auth so only the owner of a given analysis can subscribe
…loading state for now
…tured the templates
msiessedblcm
commented
Sep 29, 2025
|
|
||
| it('broadcasts an error when the LLM client throws', function () { | ||
| // Bind a permissive moderation | ||
| app()->bind(ModerationClient::class, fn () => new class implements ModerationClient { |
Collaborator
Author
There was a problem hiding this comment.
Nitpick: could use fake implementation and just making it safe by default
| }); | ||
|
|
||
| // Bind an LLM client that throws | ||
| app()->bind(LlmClient::class, fn () => new class implements LlmClient { |
Collaborator
Author
There was a problem hiding this comment.
Nitpick: can use fake llm client and force to throw exception
| <template> | ||
| <div class="min-h-screen w-full flex items-center justify-center bg-gradient-to-b from-slate-50 to-slate-100 p-6"> | ||
| <div class="w-full max-w-md"> | ||
| <div class="bg-white/90 backdrop-blur rounded-2xl shadow-xl p-8 border border-slate-200"> |
Contributor
There was a problem hiding this comment.
could have been merged with abode div
|
|
||
| <form @submit.prevent="submit" class="space-y-4"> | ||
| <div> | ||
| <label class="block text-sm font-medium text-slate-700 mb-1">Email</label> |
Contributor
There was a problem hiding this comment.
for attribute is missing
|
|
||
| <button type="submit" :disabled="loading" | ||
| class="w-full inline-flex items-center justify-center gap-2 rounded-xl bg-indigo-600 text-white font-medium px-4 py-2.5 hover:bg-indigo-700 disabled:opacity-60 disabled:cursor-not-allowed transition"> | ||
| <svg v-if="loading" class="h-5 w-5 animate-spin" viewBox="0 0 24 24" fill="none"> |
Contributor
There was a problem hiding this comment.
could have been an asset
| const email = ref('') | ||
| const password = ref('') | ||
| const { user, fetchUser } = useAuth() |
Contributor
There was a problem hiding this comment.
fetch user could have been directly chained in useAuth.
useAuth composable could have been something like :
const { user, isLoggedIn } = useAuth()
| gap: 1rem; | ||
| const sendPrompt = async () => { | ||
| if (!prompt.value.trim() || loading.value) return | ||
| loading.value = true |
Contributor
There was a problem hiding this comment.
loading.value should be mutated in useLLMChannel composable
| margin-right: 1rem; | ||
| width: 70%; | ||
| } | ||
| const envelope = computed<LlmResultEnvelope | null>(() => result.value) |
|
|
||
| <script setup lang="ts"> | ||
| import type { LlmErrorResult, LlmPayload } from '@/types/llm' |
Contributor
There was a problem hiding this comment.
type definitions are missing
| (r as LlmErrorResult).status === 'error' | ||
| </script> | ||
|
|
||
| <style scoped> |
| </div> | ||
|
|
||
| <!-- Error --> | ||
| <div v-else-if="isError(data.result)" class="rounded-xl border border-rose-200 bg-rose-50 text-rose-700 p-4" |
|
|
||
| channel = echo.private('analysis') | ||
|
|
||
| const { data } = await api.post('/api/prompt', { prompt }) |
Contributor
There was a problem hiding this comment.
should managed errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.