Skip to content

Clean Kernel-BytecodeEncoders dependencies #18140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Pharo14
Choose a base branch
from

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented May 6, 2025

  • Move EncoderForSistaV1 class>>#extensionsFor:in:into: and EncoderForSistaV1 class>>#selectorToSendOrItselfFor:in:at: to Debugging-Core because this code is calling methods from this packages and is only used in this package
  • Move InstructionStream>>#secondByte from Debugging-Core to Kernel-BytecodeEncoders because this class is using this methods and is loaded before Debugging-Core
  • Set manually resolved dependencies for this package

- Move EncoderForSistaV1 class>>#extensionsFor:in:into: and EncoderForSistaV1 class>>#selectorToSendOrItselfFor:in:at: to Debugging-Core because this code is calling methods from this packages and is only used in this package
- Move InstructionStream>>#secondByte from Debugging-Core to Kernel-BytecodeEncoders because this class is using this methods and is loaded before Debugging-Core
- Set manually resolved dependencies for this package
@guillep
Copy link
Member

guillep commented May 6, 2025

  • Move EncoderForSistaV1 class>>#extensionsFor:in:into: and EncoderForSistaV1 class>>#selectorToSendOrItselfFor:in:at: to Debugging-Core because this code is calling methods from this packages and is only used in this package

Hi @jecisc, is this true?
In my image I have several (transitive) senders of selectorToSendOrItselfFor:in:at: that are used in many places.

* Move InstructionStream>>#secondByte from Debugging-Core to Kernel-BytecodeEncoders because this class is using this methods and is loaded before Debugging-Core

This looks ok, indeed.

@jecisc
Copy link
Member Author

jecisc commented May 6, 2025

I took the latest P14 image and I have this:

image image

What other senders do you have?

@jecisc
Copy link
Member Author

jecisc commented May 6, 2025

I see that transitively we have CompiledCode>>#localMessages that is using this code. But this is only called in one other method (except a test) and this method is not called in the kernel.

So maybe they should move also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants