Simplify OSEnvironment #18038
Draft
Simplify OSEnvironment #18038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
added
the
Status: Need more work
tesonep
approved these changes
Mar 26, 2025
|
Do not merge yet, I broke something on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
OSEnvironmenthas 3 subclassesIt delegates what to do on these 3 classes. But the environment also knows the platform. And platforms have a full hierarchy to manage the different OS.
I have the impression that we are duplicating the logic of delegation depending on the OS in the environment and the platform. I'm proposing to remove the subclasses of OSEnvironment and delegate everything to the platform to simplify things.
Fixes #13272