changed pathName to asString, Fixes #17611 #18013
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
requested changes
Apr 1, 2025
| @@ -204,7 +204,7 @@ MCFileTreeAbstractReader >> packageProperties [ | |||
| on: Error | |||
| do: [ :ex | | |||
| SystemNotification signal: | |||
| 'Error reading package properties (.filetree): ' , packageDirectory pathName , ' :: ' , ex description ] ] ] ]. | |||
| 'Error reading package properties (.filetree): ' , packageDirectory asString , ' :: ' , ex description ] ] ] ]. | |||
There was a problem hiding this comment.
Suggested change
| 'Error reading package properties (.filetree): ' , packageDirectory asString , ' :: ' , ex description ] ] ] ]. | |
| 'Error reading package properties (.filetree): ' , packageDirectory pathString , ' :: ' , ex description ] ] ] ]. |
I suggest to use #pathString instead because the print is more readable than #asString. In case of relative path, #asString will not print the full path for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17611