Use separate bind and listen primitives instead of combined listenOn:… family #14593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…... family Separate primitives wrapping the bind() and listen() syscalls already exist, and have correct error/return-code handling, unlike the combined primSocket:listenOn:backlogSize: implementation. We can implement the combined version in terms of the separate ones and remove the combined primitive, significantly reducing plugin code. Also supply default values (interface and backlog size) in the image, rather than rely on the primitive to accept varargs. This allows a user to better understand the behavior without access to VM source code. Supply reduced forms of the separate bind/listen messages as the home of these default values.
|
This is intended to go with removing the Oh, and I realize I didn't make it clear in the commit message that the error-handling that exists in the separate primitives means this fixes #11723. |
|
Nice! |
|
Hi thanks for this contribution I flagged it for Pablo and he will have a look. |
|
Since Guille reviewed it and tests passed I'm merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11723
Separate primitives wrapping the bind() and listen() syscalls already exist, and have correct error/return-code handling, unlike the combined primSocket:listenOn:backlogSize: implementation. We can implement the combined version in terms of the separate ones and remove the combined primitive, significantly reducing plugin code.
Also supply default values (interface and backlog size) in the image, rather than rely on the primitive to accept varargs. This allows a user to better understand the behavior without access to VM source code. Supply reduced forms of the separate bind/listen messages as the home of these default values.
One question: Should there be an explicit socket state added for "bound but not listening or connected"?
listen()will presumably fail on an unbound socket, so overall I'd prefer to reduce dependency on such extra state not increase it, but I thought I should mention it...