Skip to content

Fixed temp vars indeces and refactor #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

jordanmontt
Copy link
Collaborator

Done with @guillep

  • The deactivator is now an object and not a block. This is to have a cleaner approach and to NOT send value when the deactivator is invoked.
  • Now obtaining the temp variables in the deactivator by index and not by name. The indeces are stored in class variables for better understanding of the code.
  • Added tests to tests that the deactivator not to send value and that the after is executed besided the exception.

… cleaner approach.

- Now obtaining the temp variables in the deactivator by index and not by name. The indeces are stored in class variables for better understanding of the code.
- Added tests to tests that the deactivator not to send value and that the after is executed besided the exception.
@jordanmontt jordanmontt merged commit 9f4dd73 into master Apr 29, 2025
12 checks passed
@jordanmontt jordanmontt deleted the fixing-value-wrapping branch April 29, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant