-
Notifications
You must be signed in to change notification settings - Fork 4
Implemented Jaro-Winkler distance algorithm #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @hernanmd @jordanmontt I have been working on this since last week, I have added implementation & verified it is working I have tried to replicate the original C implementation you provided but I was not able to understand few parts such as similar characters part (like 'O' and '0') so did not implement this part (Maybe I don't think it is required ) also I am not converting all strings to uppercase before matching as of now. Please review it whenever you get time & let me know if any improvements are needed, meanwhile I am trying to write tests for this implementation. |
I have also added Tests for the implementation |
Hello, nice! the code looks ok. the problem is that you modified a lot of files so it's difficult to review it |
Hey Jordan , I did not delete them manually I asked the same doubt in discord channel why it is getting deleted automatically ? |
Jordan correct me if I am wrong but I think CI failed due to changes in last commit you made to repo where you Refactored & used |
Fixes: #1
This PR adds the Jaro-Winkler edit distance algorithm to the existing edit distance implementations in the repository. It returns value from 0.0 (no similarity) to 1.0 (exact match).
Changes:
AIJaroWinklerDistance
class inheriting fromAIAbstractEditDistance
Screenshot: