-
Notifications
You must be signed in to change notification settings - Fork 11
Closes #97 Add {whirl} to logging article #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@bms63 tagging for the review :) |
@@ -40,7 +41,8 @@ Imports: | |||
tidyr, | |||
xportr, | |||
logr, | |||
logrx | |||
logrx, | |||
whirl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so excited to see this added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am loving this read!! @rossfarrugia FYI
I need to generate the site locally to review, but my first pass gives it an A+
thanks both - will take a look in the next week or 2 and try to coordinate this example publishing along with hopefully getting the package added to pharmaverse |
Pull Request
I have added whirl to the comparison article of the different logging packages (currently log and logrx).
In order to not change the article too much I have mostly added whirl in the existing sections, and then I added one extra section on how to execute multiple scripts with whirl.
Note that I am executing the log generation inside the Quarto document to make sure it always reflects the latest version of whirl. I see that is not the case for logr and logrx. I will be happy to update their examples to do the same, or change mine to also use a static log.
I have tested this by building webpage locally with all the latest package versions.
I was not able to link an issue, but have created #97 for his PR.
Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!
Closes #<insert_issue_number>
at the beginning of your PR title. Use the Edit button in the top-right if you need to update.DESCRIPTION
file.DESCRIPTION
file'sImports
section.