Blocking progress view #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterprokop
requested changes
Mar 14, 2017
|
|
||
| - parameter text: Text to be shown on overlay | ||
|
|
||
| - returns: Created overlay |
There was a problem hiding this comment.
But it returns UIProgressView!
|
|
||
| - returns: Created overlay | ||
| */ | ||
| open class func showBlockingProgressOverlay(_ text: String) -> UIProgressView { |
There was a problem hiding this comment.
Please check how showProgressOverlay works. It returns UIView, if programmer needs to update progress, he should use updateOverlayProgress
There was a problem hiding this comment.
I missed the updateOverlayProgress part. I will make an update to return a UIView and use updateOverlayProgress accordingly.
|
|
||
| accessoryView.frame = accessoryView.frame.offsetBy(dx: (actualSize.width - accessoryView.frame.size.width)/2, dy: padding) | ||
|
|
||
| label.center.x = accessoryView.center.x |
There was a problem hiding this comment.
Will this work with multi-line label?
|
@zmears thanks for contribution! Please check my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a blocking overlay with direct access to a progress view.