Skip to content

Conversation

NhoxxKienn
Copy link
Contributor

Description

This PR tackles the issue #33 as part of a large update #29. The aim is to upgrade the app-channel example to the actual version of go-perun v0.13.0 and other dependencies.

Location

/app-channel/

Features/ Changes

  • Update example of app-channel to go-perun 0.13.0
  • migrate from local bus to libp2p net bus
  • Update perun-eth-contracts version
  • Update and create new bindings for TicTacToe app
  • Migrate to Hardhat node for devnet (previously Ganache)
  • Update CI for app-channel

@NhoxxKienn NhoxxKienn requested review from Copilot and iljabvh May 20, 2025 08:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the app-channel example to use go-perun v0.13.0 along with related dependency upgrades and infrastructure improvements.

  • Upgrades dependencies in go.mod, including go-perun and perun-eth-backend.
  • Migrates communication from a local bus to a libp2p net bus and updates client and app implementations accordingly.
  • Updates CI workflows and Docker configuration to use Hardhat for devnet.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app-channel/util.go Adds a new wireAddr parameter to setupGameClient.
app-channel/package.json New package config with Hardhat dependency.
app-channel/main.go Migrates from local bus to libp2p net bus.
app-channel/hardhat.config.js Introduces Hardhat configuration for devnet.
app-channel/go.mod Upgrades dependency versions and Go toolchain.
app-channel/contracts/TicTacToeApp.sol Updates Solidity version and adds abicoder pragma.
app-channel/client/util.go Adjusts types to use map of wallet/backends.
app-channel/client/client.go Updates SetupAppClient and OpenAppChannel for new types.
app-channel/app/app.go Refactors TicTacToeApp to use a new AppID field.
app-channel/Dockerfile Adds Dockerfile for Hardhat node.
.github/workflows/ci.yml Updates CI to incorporate the new app-channel setup.
Comments suppressed due to low confidence (1)

app-channel/client/client.go:100

  • The variable 'waddr' is used to construct the wireAddrs map but is not defined in the revised SetupAppClient. Please declare and initialize waddr (e.g., by converting eaddress using the appropriate function) before using it in the map.
wireAddrs := map[wallet.BackendID]wire.Address{ethwallet.BackendID: waddr}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant