-
Couldn't load subscription status.
- Fork 2
Configure ada_description for Articulable Fork
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit c102e12.
…d in ada_standalone.xacro
ada_description with end_effector_tool
ada_description with end_effector_toolada_description for Articulable Fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All my comments before are small clarifications/nits. Unless you have further questions for me, feel free to merge it in after looking through/addressing the comments.
…orkHandle is reliably straight, adjust joint_origin_xyz for forkHandle_to_FTMount
…pdated forkHandle is reliably straight, adjust joint_origin_xyz for forkHandle_to_FTMount" This reverts commit 6d39728.
Description
This pull request adds a configuration to specify the
end_effector_toolwhich dynamically modifies the URDF fromada.xacro. This will allow users to specify tools fromnone,fork, andarticulable_forkthat will manifest kinematically and visually. For developers using ADA before the articulable fork hardware is transitioned in, set the tool tofork.Related PRs: #53, #54, personalrobotics/ada_feeding#211
Testing procedure
ros2 launch ada_description view_ada.launch.py end_effector_tool:=<tool>for each<tool>innone,fork, andarticulable_forknonehaving no tool,forkhaving the rigid fork assembly, andarticulable_forkhaving the articulable fork whose joints can be commanded with the slider windowBefore opening a pull request
pre-commit run --all-filespylint --recursive=y --rcfile=.pylintrc .. All warnings butfixmemust be addressed.Before Merging
Squash & Merge