fix: make rsa_pss int_to_bit_size more efficient #500
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrain99
force-pushed
the
fix/improve-rsa-verify-efficiency
branch
from
aafdec3 to
02c0e03
Compare
jfrain99
force-pushed
the
fix/improve-rsa-verify-efficiency
branch
from
02c0e03 to
dac82f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting the eflame of computing the AO token, lots of time being taken in
dev_scheduler_formats:aos2_to_assignments, specificallyrsa_pss:verifyandrsa_pss:int_to_bit_size(14% of computation time). When replacingint_to_bit_sizewith a more efficient implementation, drops to 2%. Eflames below:Before:
After: