fix(httpsig_proxy): handle {ok, Map} from with_only_committed/2 before uncommitted() #485
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted/2 before uncommitted()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Calling [email protected]/commit (and other httpsig-based commit paths) could fail or return unexpected output because the proxy fed the result of hb_message:with_only_committed/2 directly into hb_message:uncommitted/2.
Root Cause
hb_message:with_only_committed/2 returns {ok, Map}, but the code assumed it returned Map. Passing the tuple to hb_message:uncommitted/2 caused errors (e.g., badmap/function_clause) and broken outputs.
Solution
Pattern match the {ok, Map} return and pass the unwrapped Map to hb_message:uncommitted/2.
Notes
No config changes required.
Similar to a previous PR I made #446