forked from samcamwilliams/HyperBEAM
-
Notifications
You must be signed in to change notification settings - Fork 66
feat: sync from an hb store to another (FOR-139) #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jyeshe
wants to merge
11
commits into
omni/m3-b3
Choose a base branch
from
for139/store-sync
base: omni/m3-b3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+398
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f02d4b7
to
b400f52
Compare
4069cdd
to
929fe3f
Compare
jyeshe
commented
Aug 25, 2025
ok; | ||
call_all([Store = #{<<"store-module">> := Mod} | Rest], Function, Args) -> | ||
try apply_store_function(Mod, Function, Store, Args) | ||
try apply_store_function(Mod, Store, Function, Args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatter agent merit
2d2bb32
to
dbc143f
Compare
dbc143f
to
9898629
Compare
9898629
to
51c711b
Compare
* refactor: allow store shallow reads for links * refactor: rename symlink to link More generic for stores other than hb_store_fs * fix: prevent resolve on hb_store_fs:read with follow-link false * refactor: rename follow-link to resolve We just needed to skip resolve on the previous commit to get the link destination path instead of its content
22dc07a
to
cf54786
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Copies the entries from one store to another using hb_store behaviour (in a store agnostic way).
Note on scope: this implementation was tested only on local stores, more specifically syncing from
hb_store_fs
tohb_store_lmdb
Why
Use cases from FOR-139:
How to use
Validation steps
?DEFAULT_PRIMARY_STORE
inhb_opts:default_message
rm -rf cache-*
S5iWl7L76dBpvrm-i_SRWODchdLYBGwYeSrIxC8v-vI
)?DEFAULT_PRIMARY_STORE
and restart HyperBEAMresolve=false
is used to allow syncing links):Addtional Notes
TBD:
sync
returns{error, {sync_failed, FailedKeyValues}}