-
Notifications
You must be signed in to change notification settings - Fork 10
Create enforcement.md - Encryption Enforcement topic #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-17.5.2
Are you sure you want to change the base?
Conversation
populated with encryption enforcement
updated with future steps to enforce encrypt
…postgres into docs-create-enforcement
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #403 +/- ##
==================================================
- Coverage 84.66% 84.65% -0.01%
==================================================
Files 21 21
Lines 2589 2588 -1
Branches 402 401 -1
==================================================
- Hits 2192 2191 -1
Misses 316 316
Partials 81 81
🚀 New features to boost your workflow:
|
updated with pg_tde enforce encryption option
…postgres into docs-create-enforcement
removed table space encryption
updated the enforce_encryption description
added a note that clarifies unauthorized user access and how superusers can still bypass the forced encryption table creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now my generic problem with this PR is that this new page doesn't provide any additional information compared to the GUC page. In fact, it provides less, as the GUC page at least explains to an extent what are the different allowed scopes of the variable.
Jan asked for scenarios to be documented, I guess he meant things like:
- Specific example how to enforce encryption to the entire server
- Specific example how to enforce encryption to only a single database with
ALTER DATABASE SET
- Example that superusers can override the variable at session level, so that they can create non encrypted tables in that session (the usecase I described on slack)
- Maybe also an example of enforcing encryption to a specific user with
ALTER USER
Which is basically adding actual examples to the "Use the following techniques..." section
small update to the note describing superuser actions properly
Writing a general topic regarding Encrpytion Enforcement from pg_tde perspective, requires heavy review.