K8SPXC-1581 fix '--defaults-file' option issue #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix CS0052089: --defaults-file must be specified first on command line - Extract --defaults-file from XB_EXTRA_ARGS and place as first argument - Apply fix to both recovery-cloud.sh and recovery-pvc-joiner.sh - Maintain backward compatibility for configurations without --defaults-file - Support any order of arguments in containerOptions.args.xtrabackup This resolves the error: '--defaults-file must be specified first on the command line' when using --defaults-file in restore containerOptions configuration.
Resolved conflicts in backup scripts to include --defaults-file fix: - Keep the --defaults-file extraction logic from main branch - Apply the fix to both recovery-cloud.sh and recovery-pvc-joiner.sh - Ensure --defaults-file is always the first argument in xtrabackup commands
- Move --defaults-file extraction logic before innobackupex commands - Apply the same fix to both recovery-cloud.sh and recovery-pvc-joiner.sh - Ensure --defaults-file is first argument for both xtrabackup and innobackupex - Update comment to reflect both utilities are supported This ensures consistency and prevents --defaults-file ordering errors in both xtrabackup and innobackupex commands.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # This fixes the issue where --defaults-file must be the first argument for xtrabackup and innobackupex | ||
| DEFAULTS_FILE="" | ||
| REMAINING_XB_ARGS="" | ||
| if [[ "$XB_EXTRA_ARGS" =~ --defaults-file=([^[:space:]]+) ]]; then |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [[ "$XB_EXTRA_ARGS" =~ --defaults-file=([^[:space:]]+) ]]; then | |
| if [[ $XB_EXTRA_ARGS =~ --defaults-file=([^[:space:]]+) ]]; then |
| # This fixes the issue where --defaults-file must be the first argument for xtrabackup and innobackupex | ||
| DEFAULTS_FILE="" | ||
| REMAINING_XB_ARGS="" | ||
| if [[ "$XB_EXTRA_ARGS" =~ --defaults-file=([^[:space:]]+) ]]; then |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [[ "$XB_EXTRA_ARGS" =~ --defaults-file=([^[:space:]]+) ]]; then | |
| if [[ $XB_EXTRA_ARGS =~ --defaults-file=([^[:space:]]+) ]]; then |
hors
requested review from
egegunes,
eleo007,
gkech,
jvpasinatto,
nmarukovich,
pooknull and
valmiranogueira
as code owners
commit: 807c896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
This ensures consistency and prevents --defaults-file ordering errors
in both xtrabackup and innobackupex commands."
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability