K8SPXC-1327: Make jemalloc the default memory allocator #2002
+91
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/K8SPXC-1327 Problem: By default, standard libc allocator is used by PXC. It is often desirable to use jemalloc instead. To do so, use has to configure LD_PRELOAD environment variable. The only way to do this is through k8s secret. Solution: Extended PodSpec object with MySqlAllocator property. If it is empty, omitted or set to 'jemalloc', LD_PRELOAD env variable pointing to jemalloc library will be exported. Otherwise the default allocator will be used.
kamil-holubicki
requested review from
egegunes,
gkech,
hors,
nmarukovich and
pooknull
as code owners
|
|
kamil-holubicki
requested review from
egegunes
and removed request for
egegunes
hors
reviewed
Mar 14, 2025
deploy/cr.yaml
Outdated
| size: 3 | ||
| image: perconalab/percona-xtradb-cluster-operator:main-pxc8.0 | ||
| autoRecovery: true | ||
| # mySqlAllocator: jemalloc |
There was a problem hiding this comment.
In cr we have a commented option with a default value. In our doc, we will add all possible values. Also, you can add them in CRD. It is possible to add validation on CRD level.
There was a problem hiding this comment.
In cr we have a commented option with a default value. In our doc, we will add all possible values.
Done
Also, you can add them in CRD. It is possible to add validation on CRD level.
I'm not sure I understand where and what to add.
https://perconadev.atlassian.net/browse/K8SPXC-1327 Logic simplified. LD_PRELOAD is set always via appc.Env.
egegunes
reviewed
Mar 25, 2025
egegunes
previously approved these changes
Mar 28, 2025
gkech
reviewed
Mar 28, 2025
pkg/pxc/app/statefulset/node.go
Outdated
Comment on lines
308
to
313
| appc.Env = append(appc.Env, []corev1.EnvVar{ | ||
| { | ||
| Name: LD_PRELOAD_KEY, | ||
| Value: ldPreloadValue, | ||
| }, | ||
| }...) |
There was a problem hiding this comment.
Since we are setting only one env var, we can simplify this using the following:
appc.Env = append(appc.Env, corev1.EnvVar{
Name: LD_PRELOAD_KEY,
Value: finalLDPreload,
})
pkg/pxc/app/statefulset/node.go
Outdated
Comment on lines
271
to
272
| const LD_PRELOAD_KEY = "LD_PRELOAD" | ||
| const LIBJEMALLOC_PATH = "/usr/lib64/libjemalloc.so.1" |
There was a problem hiding this comment.
The convention is to use camel case to define constants. They can also start with lowercase given that their scope is within the if clause of 1.18 version.
We can also group them like this:
const (
ldPreloadKey = "LD_PRELOAD"
libJemalloc = "/usr/lib64/libjemalloc.so.1"
)
Comment on lines
285
to
291
| // Env vars are set via secret. Check if LD_PRELOAD is set. | ||
| for key, value := range envVarsSecret.Data { | ||
| if key == LD_PRELOAD_KEY { | ||
| ldPreloadValue = string(value) | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
We can avoid this loop completely by using
if val, ok := envSecret.Data[LdPreloadKey]; ok {
ldPreload = string(val)
}
Data of secret are of type map[string][]byte .
https://perconadev.atlassian.net/browse/K8SPXC-1327 Addressed review comments.
kamil-holubicki
force-pushed
the
K8SPXC-1327
branch
from
94ebe85 to
9b9576e
Compare
gkech
previously approved these changes
Mar 31, 2025
https://perconadev.atlassian.net/browse/K8SPXC-1628 Extended solution for K8SPXC-1327 to allow usage of tcmalloc.
commit: 9ccc2eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1327
Problem:
By default, standard libc allocator is used by PXC. It is often desirable to use jemalloc instead. To do so, use has to configure LD_PRELOAD environment variable. The only way to do this is through k8s secret.
Solution:
Extended PodSpec object with MySqlAllocator property. If it is empty, omitted or set to 'jemalloc', LD_PRELOAD env variable pointing to jemalloc library will be exported.
Otherwise the default allocator will be used.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability