Improve time offset ux

[Boy132]

Supersedes #1771

• Hide offset field when creating the first task
• Hide offset in table for first task
• Improve "seconds" translation

[coderabbitai]

📝 Walkthrough

Walkthrough

Adjusts how time_offset is presented: hides the field for first or sole tasks, pluralizes the seconds label via trans_choice, and updates table rendering to show placeholders or dynamic suffixes based on task sequence. Adds a new translation key for "First Task".

Changes

Cohort / File(s)	Summary
Tasks relation UI logic app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php	getTaskForm now hides time_offset when schedule has zero tasks or for the first task; time_offset input suffix uses trans_choice('server/schedule.tasks.seconds', 2). Table column sets time_offset to null for sequence_id == 1, shows a placeholder for the first task, and uses trans_choice suffix for subsequent tasks.
Translations (en) lang/en/server/schedule.php	Added tasks.first_task = "First Task". Updated tasks.seconds to a pluralized form Second|Seconds.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor User
    participant UI as Filament TasksRelationManager
    participant I18n as Translations

    rect rgba(230,240,255,0.5)
    note over UI: Form rendering
    User->>UI: Open Task Form
    UI->>UI: Read schedule task count and task.sequence_id
    alt first task or no other tasks
        UI->>UI: Hide time_offset input
    else subsequent task
        UI->>I18n: trans_choice("server/schedule.tasks.seconds", n)
        I18n-->>UI: "Second"/"Seconds"
        UI->>User: Render time_offset with pluralized suffix
    end
    end

    rect rgba(235,255,235,0.5)
    note over UI: Table rendering
    User->>UI: View Tasks Table
    loop for each task
        UI->>UI: Check task.sequence_id
        alt sequence_id == 1
            UI->>User: Show placeholder / null for time_offset (e.g., "First Task")
        else sequence_id > 1
            UI->>I18n: trans_choice("server/schedule.tasks.seconds", n)
            I18n-->>UI: "Second"/"Seconds"
            UI->>User: Show time_offset with suffix
        end
    end
    end

Loading

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “Improve time offset ux” concisely captures the primary change by emphasizing user-experience enhancements for the time offset feature, making it clear and specific enough for teammates to understand the update at a glance.
Description Check	✅ Passed	The description directly relates to the changes by outlining the key updates—hiding the offset for the first task and improving the seconds translation—so it clearly reflects the pull request’s content.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08b4dbd and b8ffba4.

📒 Files selected for processing (1)

• app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (1)

80-80: Consider using the actual field value for pluralization.

The hardcoded count of 2 forces the plural form "Seconds" in all cases. For improved UX, consider using the actual time_offset value to display the correct singular/plural form dynamically.

Apply this diff to use the actual field value:

-                ->suffix(trans_choice('server/schedule.tasks.seconds', 2)),
+                ->suffix(fn (Get $get) => trans_choice('server/schedule.tasks.seconds', $get('time_offset') ?? 2)),

Note: This would require the field to be live() for dynamic updates as the user types, which may add complexity. The current approach is acceptable if you prefer simplicity.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19103b1 and 08b4dbd.

📒 Files selected for processing (2)

• app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (2 hunks)
• lang/en/server/schedule.php (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (2)

app/Models/Schedule.php (1)

• tasks (133-136)

app/Models/Task.php (1)

• Task (27-123)

🔇 Additional comments (4)

lang/en/server/schedule.php (2)

80-80: LGTM!

The new translation key for "First Task" is correctly added and aligns with the PR objective to improve UX for the first task in a schedule.

---

81-81: LGTM!

The pluralization format using pipe separator (Second|Seconds) is correct for Laravel's trans_choice() function. This enables proper singular/plural handling based on the time offset value.

app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (2)

75-75: LGTM!

The added condition $schedule->tasks->count() === 0 correctly hides the time_offset field when creating the first task in an empty schedule. Combined with the existing $get('sequence_id') === 1 check for editing the first task, this properly implements the PR objective to hide the offset field for first tasks.

---

111-113: LGTM!

The table column logic correctly implements the PR objective:

1. Line 111: Applies a pluralized suffix only for non-first tasks, using the actual time_offset value for proper singular/plural handling.
2. Line 112: Returns null for the first task to trigger the placeholder, and the actual time_offset value for subsequent tasks.
3. Line 113: Displays "First Task" placeholder when the state is null (first task only).

The logic flow ensures:

• First task displays: "First Task" (no offset shown)
• Subsequent tasks display: "123 seconds" or "1 second" (with proper pluralization)