i_1135 fix WTI package build for correct zip/gz file names #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distribution files for the WTI were improperly named for local (non-github) builds and for PR triggered workflow builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Distribution files for the WTI were improperly named for local (non-github) builds and for PR triggered workflow builds.
For non-github package builds, the WTI project distribution files are now named:
WebTeamInterface-1.2-7784.zipandWebTeamInterface-1.2-7784.tar.gzinstead ofWebTeamInterface-1.2-.zipandWebTeamInterface-1.2-.tar.gzIn addition, for github PR triggered workflow builds, the distribution files are now in the project's
distfolder namedWebTeamInterface-1.2-7784~pri1135_fix_pr_build_artifacts.zipandWebTeamInterface-1.2-7784~pri1135_fix_pr_build_artifacts.tar.gzinstead ofWebTeamInterface-1.2-7784~1136/merge.zipandWebTeamInterface-1.2-7784~1136/merge.tar.gzThis should also have the side effect of including the
projects/WebTeamInterface-1.2-7784~~pri1135_fix_pr_build_artifacts.zipin the Github workflow artifactbuild.zipfile. Previously it was not included since it was named improperly (merge.zip) in a subfolder.Issue which the PR addresses
Fixes #1135
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11
Ant 1.10.12
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
projects/distfolder and verify the name of the WebTeamInterface zip and gz files are as described above.dist/pc2-9.11build-XXXX.zipfile and see that it containsprojects/WebTeamInterface-1.2-XXXX.zipTo check the Github artifacts, find the Workflow run for this PR and examine the
merge.zipartifact it produced. It should contain apc2-9.11build-7261~1136/merge.zip/pc2-9.11build/projects/WebTeamInterface-1.2-7261~pri1135_fix_pr_build_artifacts.zipWTI installation zip.Note: these changes should NOT affect the nomenclature for develop and master merges.