Skip to content

another fix to bobbit's IRC maximum message length #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: bobbit-0.2.x
Choose a base branch
from
Open

another fix to bobbit's IRC maximum message length #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00a812
use length in bytes of message/command to determine when to wrap IRC …
antithalian Feb 23, 2024
50a0d39
changes bobbit to use a more conservative max message length for IRC
antithalian Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/bobbit/protocol/irc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@
NICK_RE = re.compile(r':(?P<old_nick>.*?)!\S+\s+?NICK\s+(?P<new_nick>[^\s]+)')
REGISTERED_RE = re.compile(r':NickServ!.*NOTICE.*:.*(identified|logged in|accepted).*')

MESSAGE_LENGTH_MAX = 512 - len(CRNL)
# NOTE: IRC message length limit is 512 bytes, but that includes the sender's hostmask
# since the hostmask can change during a session, the simplest way to ensure messages are under 512 bytes
# is to set a conservative maximum like 400
# so few bobbit messages are that long that it shouldn't cost too many extra messages being sent
MESSAGE_LENGTH_MAX = 400

# IRC Client

Expand Down Expand Up @@ -149,9 +153,10 @@ async def send_message(self, message):
if isinstance(message, Message):
message = self.format_message(message)

if len(message) > MESSAGE_LENGTH_MAX:
# NOTE: use str.encode() to determine length of message/command since IRC only cares about number of bytes
if len(message.encode()) > MESSAGE_LENGTH_MAX:
command, message = message.split(' :', 1)
messages = [f'{command} :{m}' for m in textwrap.wrap(message, MESSAGE_LENGTH_MAX - len(command) - 2)]
messages = [f'{command} :{m}' for m in textwrap.wrap(message, MESSAGE_LENGTH_MAX - len(command.encode()) - 2)]
else:
messages = [message]

Expand Down