-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add expand parameter support to experimental live loader #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
next
Choose a base branch
from
copilot/add-expand-parameter-live-loader
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f915c1e
feat(live-loader): add experimental expand parameter support
Copilot 3be932a
test(schema): add collection id to tests
pawcoding 581ea8b
docs(README): add documentation for expand parameter in live loader
Copilot 7afc0fc
test(loader): add test cases for expand option
Copilot d2d746c
ci(release): update pre-release publishing
pawcoding 2801ede
chore(release): 2.10.0-live-expand.1 [skip ci]
semantic-release-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { PocketBaseConfigurationError } from "../types/errors"; | ||
|
|
||
| /** | ||
| * Maximum nesting depth for expand relations as enforced by PocketBase | ||
| */ | ||
| const MAX_EXPAND_DEPTH = 6; | ||
|
|
||
| /** | ||
| * Format and validate expand option for PocketBase API requests. | ||
| * Validates nesting depth and returns formatted expand string. | ||
| */ | ||
| export function formatExpand( | ||
| expand: Array<string> | undefined, | ||
| collectionName: string | ||
| ): string | undefined { | ||
| if (!expand || expand.length === 0) { | ||
| return undefined; | ||
| } | ||
|
|
||
| // Validate each expand field for maximum nesting depth and invalid characters | ||
| for (const field of expand) { | ||
| // Check for comma in field name | ||
| if (field.includes(",")) { | ||
| throw new PocketBaseConfigurationError( | ||
| collectionName, | ||
| `Expand field "${field}" contains a comma. Use separate array entries instead of comma-separated values.` | ||
| ); | ||
| } | ||
|
|
||
pawcoding marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const depth = (field.match(/\./g) || []).length + 1; | ||
| if (depth > MAX_EXPAND_DEPTH) { | ||
| throw new PocketBaseConfigurationError( | ||
| collectionName, | ||
| `Expand field "${field}" exceeds maximum nesting depth of ${MAX_EXPAND_DEPTH} levels.` | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // Join all expand fields with comma as required by PocketBase | ||
| return expand.join(","); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.