feature: encoding/mvt: add brotli support #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but why? wikipedia says Brotli is optimized for text data like javascript, html and css. MVT is protobuf. |
|
Good question! Unfortunately I don't have a great answer other than "it's an alternative" and "it's widely supported in all major web browsers." I don't have any benchmarks to say it's better or faster at this time. My use case was mainly seeing if I could use brotli compression for a web server endpoint returning MVT, and because it was quick to implement (huge thanks to this wonderful lib) I figured I'd make a PR to share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added support for brotli compression to the encoding package with updates to encoding tests as well