Skip to content

add firstRessource timers #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add firstRessource timers #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,24 @@ function extractFramesFromTimeline(timeline, opts) {
// add white frame to beginning of trace
const fakeWhiteFrame = frame(synthesizeWhiteFrame(uniqueFrames), startTs);
uniqueFrames.unshift(fakeWhiteFrame);
const resourceReceived = events.filter(e => e.name === "ResourceReceiveResponse");
let firstRessource = -1;
if (resourceReceived.length > 0) {
const firstEvtData = resourceReceived[0].args.data.timing;
if (firstEvtData !== undefined) {
firstRessource = {
dns: firstEvtData.dnsEnd,
ssl: firstEvtData.sslEnd,
firstByte: firstEvtData.receiveHeadersEnd
};
}
}

const data = {
startTs,
endTs,
frames: uniqueFrames
frames: uniqueFrames,
firstRessource: firstRessource
};
return Promise.resolve(data);
}
Expand Down
1 change: 1 addition & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ function calculateValues(frames, data) {
return {
beginning: data.startTs,
end: data.endTs,
firstRessource: data.firstRessource,
frames,
first,
complete,
Expand Down
3 changes: 3 additions & 0 deletions test/speed-index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ test('speed indexes calculated for realistic trace', async t => {
const indexes = speedIndex.calculateSpeedIndexes(data.frames, data);
t.is(Math.floor(indexes.speedIndex), 542);
t.is(Math.floor(indexes.perceptualSpeedIndex), 578);
t.is(Math.floor(data.firstRessource.dns), 55);
t.is(Math.floor(data.firstRessource.ssl), 80);
t.is(Math.floor(data.firstRessource.firstByte), 234);
});

test('speed indexes calculated with --fast', t => {
Expand Down