-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: Update mongodb runner to fix ESRCH error when running tests #9860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
fix: Update mongodb runner to fix ESRCH error when running tests #9860
Conversation
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughDocumentation updated to include a troubleshooting step for MongoDB runner ESRCH errors. package.json updates bump mongodb-runner devDependency from 5.8.3 to 5.9.3 and add a new npm script clean:mongodb to prune the runner cache. No runtime code or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
I will reformat the title to use the proper commit message syntax. |
@mtrezza for current active contributors, they need to run the "clean:mongodb" script to prune some old ref, then the upgrade of the package seems to fix the issue 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CONTRIBUTING.md (1)
518-519
: Good addition; consider surfacing this under Troubleshooting, too.The note is helpful and scoped. To improve discoverability, mirror this line under the “Troubleshooting” section (Lines 217–231) with the same command.
package.json (1)
140-146
: Nice: dedicated cleanup script. Optional: add a “clean:testenv” combo.A convenience alias helps when CI/local runs leave stale state. Example:
"posttest": "cross-env mongodb-runner stop --all", "clean:mongodb": "cross-env mongodb-runner prune", + "clean:testenv": "cross-env mongodb-runner stop --all && cross-env mongodb-runner prune", "coverage": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=8.0.4} MONGODB_TOPOLOGY=${MONGODB_TOPOLOGY:=standalone} TESTING=1 nyc jasmine",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (2)
CONTRIBUTING.md
(1 hunks)package.json
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: Node 20
- GitHub Check: MongoDB 8, ReplicaSet
- GitHub Check: PostgreSQL 15, PostGIS 3.4
- GitHub Check: Docker Build
- GitHub Check: MongoDB 7, ReplicaSet
- GitHub Check: PostgreSQL 15, PostGIS 3.3
- GitHub Check: Node 18
- GitHub Check: PostgreSQL 17, PostGIS 3.5
- GitHub Check: MongoDB 6, ReplicaSet
- GitHub Check: PostgreSQL 15, PostGIS 3.5
- GitHub Check: Redis Cache
- GitHub Check: PostgreSQL 16, PostGIS 3.5
🔇 Additional comments (1)
package.json (1)
106-106
: Provide upstream changelog/commit proving ESRCH ('kill ESRCH') fix in mongodb-runner v5.9.3No release note or changelog entry explicitly mentions an ESRCH / "kill ESRCH" cleanup fix in v5.9.3. Add a direct link to the upstream changelog/commit/PR in the PR description (or a short note here) showing the fix so reviewers can verify the rationale for the version bump.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #9860 +/- ##
==========================================
- Coverage 92.99% 92.57% -0.43%
==========================================
Files 187 187
Lines 15096 15096
Branches 174 174
==========================================
- Hits 14039 13975 -64
- Misses 1045 1105 +60
- Partials 12 16 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Issue
Closes: Mongodb runner clean issue
Approach
Update the package
Tasks
Summary by CodeRabbit
Documentation
Chores