voter: Stop the voter logic on terminated global input stream #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
changed the title
rphmeier
reviewed
Jun 3, 2025
| warn!( | ||
| target: LOG_TARGET, | ||
| ?err, | ||
| "Possible case of massive equivocation: \ |
There was a problem hiding this comment.
probably don't want this log line to trigger if it's a stream-closed error.
andresilva
approved these changes
Jun 4, 2025
Signed-off-by: Alexandru Vasile <[email protected]>
andresilva
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the voter logic stops when the
global_instream is terminated.While at it, have replaced the
logdependency withtracing