Modified the code to accommodate terminal unmodified amino acids following patterns eg. K$

[anilkmg]

Hi Chris,

Using regex to match the terminal amino acid with peptide sequence is enabled without affecting rest of the code. I have tested with our project data (TNK2 BioSITe). You can follow your routine test procedures before merging with your master branch.

Regards,
Anil

[anilkmg]

biotin_3state_term.txt

Is the label-scheme file used to test and analyze this SILAC proteomics data.

[Chris7]

Pull requests should target chris7/pyquant as that has the build cycle enabled. This fork can be sync'd but I don't see the point in having this feature only in a fork

[Chris7]

Going forward, everything needs to be tested. All of my changes have been accompanied with new unit tests and making the code less complex and made of smaller parts that are functions (so each function can be individually tested without a bunch of side-effects)

[Chris7]

Anil,

Thanks for the PR. You can test stuff via Make testenv and Make test. I would perform tests on small additions like so: nosetests pyquant.tests.test_utils and so on.

[anilkmg]

Hi Chris,

I will also send a PR to chris7/pyquant. I am getting used to add test features. If will reflect in upcoming projects on GitHub.

[Chris7]

You can keep it here and send a pr after it's in master here.

…

On Nov 16, 2017 8:56 PM, "Anil Madugundu" ***@***.***> wrote: Hi Chris, I will also send a PR to chris7/pyquant. I am getting used to add test features. If will reflect in upcoming projects on GitHub. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA61RQIbAuMUjsfOuwjVuEzD9MPNQaWcks5s3OfMgaJpZM4QhKph> .

[Chris7]

Here's an example of what you should have:

Chris7#28

[anilkmg]

Thanks Chris.

…

On Sun, Nov 19, 2017 at 3:36 PM, Chris Mitchell ***@***.***> wrote: Here's an example of what you should have: Chris7#28 <Chris7#28> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMWZULhtPjBywKCePDVXCb0rcGFJM11Kks5s4JE9gaJpZM4QhKph> .