-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Remove ALL gitpod/docker/devcontainer related files and docs #62859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove ALL gitpod/docker/devcontainer related files and docs #62859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the documentation, I think we might as well remove the other related files. So could you remove other reference or files related to Dockerfile or Gitpod?
EDIT: Also possibly good timing to remove Gitpod, looks like they're rebranding/refocusing efforts as well https://github.com/gitpod-io/gitpod/blob/main/README.md
|
@mroeschke should I also remove |
Yes please. And any files or lines in files that used |
Not sure if I should also delete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM! Going to leave this open for a little bit just in case there are comments from others
closes BUG: Dockerfile doesn't install pandas directly #62429 (Replace xxxx with the GitHub issue number)
closes # DEV: Gitpod integration #47790 (Replace xxxx with the GitHub issue number)
closes BUILD: meson build step generate_version.py fails in Docker container in Windows #55170 (Replace xxxx with the GitHub issue number)
closes BUILD: pandas build failing on Gitpod due to Meson #55214 (Replace xxxx with the GitHub issue number)
closes DOC: Development on Gitpod have problems #59459 (Replace xxxx with the GitHub issue number)
closes BUG: Dockerfile doesn't install pandas directly #62429 (Replace xxxx with the GitHub issue number)
closes ENH: devcontainer & docker: use cases and improvements #54862 (Replace xxxx with the GitHub issue number)
Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new featureAll code checks passed.Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.