Support async views. Fixes #91 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davidism
reviewed
Aug 29, 2025
pyproject.toml
Outdated
| requires-python = ">=3.7" | ||
| dependencies = [ | ||
| "Flask", | ||
| "Flask[async]", |
There was a problem hiding this comment.
Don't make the async extra a requirement. ensure_sync will fail with an error message explaining the extra once a project actually uses async views.
There was a problem hiding this comment.
sure. but for the tests to pass I had to add it to requirements/test.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #91 by following guidance from Flask docs.
This was initially done inside a bigger PR by @MarekPikula here however that branch is very much out of date with HEAD.