Skip to content

Conversation

tonkatsu-wallwisher
Copy link
Contributor

This version removes the api project(':padlet_rn-foundation') declaration which the main mobile app is currently patching (which shouldn't really be needed).

@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 10:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a dependency on RNFoundation and bumps the package version to address compatibility issues with the main mobile app. The change eliminates the need for the main app to patch the RNFoundation dependency.

  • Remove the padlet_rn-foundation project dependency from Android build configuration
  • Bump package version from 1.2.1 to 1.2.2

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updates version number to 1.2.2
android/build.gradle Removes the padlet_rn-foundation project dependency

@tonkatsu-wallwisher tonkatsu-wallwisher requested review from a team, SaphiraNgocThuy, asleepace, quekshuy and thespacemanatee and removed request for a team July 30, 2025 10:47
Copy link
Contributor

@quekshuy quekshuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging have to git-tag as v1.2.2

@quekshuy quekshuy force-pushed the tonkatsu/remove-rnfoundation-requirement branch from f92d672 to 1e08335 Compare September 13, 2025 17:00
@quekshuy quekshuy merged commit 13a614f into master Sep 17, 2025
2 checks passed
@quekshuy quekshuy deleted the tonkatsu/remove-rnfoundation-requirement branch September 17, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants