Skip to content

Conversation

@donn-xx
Copy link

@donn-xx donn-xx commented Apr 11, 2023

Paddy,
I don't know why you're so short with me. I can't work out how to chop things into individual commits per node. Instead here is all my work - as clean as I could get it.

There is a change in your examples.tscn, which you can revert/ignore -- I was trying to fix the box and circle demos.

I've done a lot of work and this is the best I can offer you. I hope you can find the patience to pick what you will from the nodes done.

When I see you release some of my nodes, then I'll feel better about making new ones. In the meantime, I won't mutate the donnv4 branch any further.

Best,
/d

paddy-exe and others added 4 commits April 8, 2023 16:59
Tuned the box and circle code and demos
Added my latest work afresh
@paddy-exe paddy-exe added the ✨ enhancement New feature or request label Apr 11, 2023
@paddy-exe
Copy link
Owner

paddy-exe commented Apr 11, 2023

Hey Donn, sorry if I come off a bit rough. It's important for me to have little overhead when others want to contribute to my addons. I don't have much time on my hands so having a good PR which in details explains already the changes that were added in the PR description, doesn't contain too much content for me to review and which keeps a similar/ the same structure I already built up takes a lot off my plate
I am very thankful for your contribution and I hope you won't abandon open-source but please get more familiar with git and GitHub when contributing through these tools. Granted, I don't have a Contributor's Guide but for many other open-source projects basic knowledge in Git and GitHub is required. Now for the structure of my addons: In the beginning you completely disregarded the structure I built up. Naming your demo folder after yourself falls in the same category but I get your sentiment of giving me an overview. However if you filled out the description of your PR and kept your PRs smaller like I suggested, this would be much smaller. Please keep that in mind for the future and please correct this when you read this. By description I mean a list of the Nodes you added, their effects/use-case and screenshots. To keep these showcases small and embed them in clickable sections, please refer to this guide: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections

Now about your changes. The nodes and example scene that I think are usable because they effectively show the effects are:

  • blur_2d_demo
  • color_mask_2d_demo
  • normalmap_z_3d_demo
  • pmap_3d_demo
  • hexagonal_demo
  • Smooth Box (only inside the already available Shapes showcase -> not their own demo)
  • Smooth Circle (only inside the already available Shapes showcase) -> not their own demo
  • texture_stack_3d_demo
  • tiler_2d_demo -> should be renamed to brick_tiler
  • wn_mask_demo
  • wn_mixer_demo

If you read this comment and still want to work on this, give it a 👍🏻 as a reaction and I will delete it. I implore you as well to clean the description of your PR and add the description of your changes like described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants