fix: Decimal conversion with too many low digits #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacman82
requested changes
Apr 9, 2025
| n | ||
| } | ||
|
|
||
| trait ToDecimal: | ||
| FromRadix10 + FromRadix10Signed + Add<Output = Self> + Sub<Output = Self> + MulAssign + Ord | ||
| FromRadix10 + FromRadix10Signed + Add<Output = Self> + Sub<Output = Self> + MulAssign + std::ops::Div<Output = Self> // Add Div requirement for right-shifting |
There was a problem hiding this comment.
- Could we use
DivAssigninstead ofCopyandDiv?
There was a problem hiding this comment.
Unfortunately, no. Using DivAssign instead of Div and Copy results in:
cannot divide `I` by `I`
consider further restricting type parameter `I` with trait `Div`: ` + std::ops::Div<Output = I>`| n | ||
| } | ||
|
|
||
| trait ToDecimal: | ||
| FromRadix10 + FromRadix10Signed + Add<Output = Self> + Sub<Output = Self> + MulAssign + Ord | ||
| FromRadix10 + FromRadix10Signed + Add<Output = Self> + Sub<Output = Self> + MulAssign + std::ops::Div<Output = Self> // Add Div requirement for right-shifting | ||
| + Ord |
There was a problem hiding this comment.
Why do we need Ord don't we only compare usize if we count digits?
There was a problem hiding this comment.
I don't know, Ord was a trait bound that already existed. I tried removing it, and some errors for equality occur:
binary operation `<` cannot be applied to type `I`binary operation `==` cannot be applied to type `I`We could use PartialEq and PartialOrd instead, but it's basically equivalent to Ord anyway.
|
Merged and released, thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
For example, when performing an
avg()query with a decimal source column, the output avg column receives a scale of(_, 6)but the actual data received was a decimal with 16 fractional digits (e.g.12.3456789000000000). In this example, we truncate the digits to the specified scale for the field leaving behind the actual data of12.345678.Depending on the query, the existing behavior can result in panics from subtraction overflow. For example: spiceai/spiceai#1907