[hakari] use final-excludes rather than traversal-excludes #8707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at build performance I realized that we weren't unifying feature sets across rust-analyzer builds and ones done on the command line. Switching from traversal-excludes (i.e. omitted while computing the set of features for each package) to final-excludes (removed at the very end) addresses this issue.
This doesn't completely unify all feature sets (e.g. we have a few
testing
features within the workspace that can't be unified), but it does ensure that third-party dependencies are shared across all builds.With this change, after running a
cargo check
withinrust-analyzer
: