Add official GitHub star count button above the fold #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabek
reviewed
Apr 17, 2025
layouts/index.html
Outdated
| @@ -7,6 +7,7 @@ | |||
| </figure> | |||
|
|
|||
| <div class="intro col-lg-7 col-md-16"> | |||
| <a class="github-button" href="https://github.com/owncast/owncast" data-color-scheme="no-preference: dark; light: dark; dark: dark;" data-size="large" data-show-count="true" aria-label="Star owncast/owncast on GitHub">Star</a> | |||
There was a problem hiding this comment.
This label says "star owncast on github" but pressing this button will not star Owncast on github.
There was a problem hiding this comment.
It is designed to work like that only because of security issues- buttons/github-buttons#10
There was a problem hiding this comment.
I know why, but I'm just saying it's not accurate. It's not possible to star a repository this way, so we shouldn't say that the button does so.
There was a problem hiding this comment.
Would it be better to write "View owncast/owncast on Github" as the aria label and "Github" as button label?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4280 add official GitHub star count button in hero section, which is above the fold