feat(combobox): implement component #807
Conversation
var-poro
force-pushed
the
ods-react-combobox
branch
from
271a191 to
44c6a33
Compare
| @@ -0,0 +1,96 @@ | |||
| import type { ComboboxProp } from '../../context/useCombobox'; | |||
| export type ComboboxProp = Omit<ComponentPropsWithRef<'div'>, 'onSelect'> & { | ||
| allowCustomValue?: boolean, | ||
| children?: ReactNode, | ||
| className?: string, |
There was a problem hiding this comment.
children and className already come from ComponentPropsWithRef
| children?: ReactNode, | ||
| className?: string, | ||
| customOptionRenderer?: (item: ComboboxItemOrGroup) => JSX.Element, | ||
| defaultValue?: string[] | undefined, |
There was a problem hiding this comment.
remove | undefined, the ? already does the same
|
|
||
| interface ComboboxContextType { | ||
| allowCustomValue: boolean; | ||
| customOptionRenderer?: (item: ComboboxItemOrGroup) => ReactNode; |
There was a problem hiding this comment.
=> JSX.Element to be inline with the customOptionRenderer return type of ComboboxProp
| value?: string[] | ||
| } | ||
|
|
||
| interface ComboboxContextType { |
There was a problem hiding this comment.
type ComboboxContextType = ComboboxProp & { ... custom prop }?
This will also avoid this diff between those two regarding ?
| { label: 'Goldfish', value: 'goldfish' }, | ||
| ]} | ||
| value={value} | ||
| onValueChange={details => setValue(details.value ?? [])} |
There was a problem hiding this comment.
can detail.value actually be undefined?
| noResultLabel = 'No results found', | ||
| onValueChange, | ||
| readOnly = false, | ||
| value = [], |
There was a problem hiding this comment.
leave empty as other components
| newElementLabel = 'Add ', | ||
| noResultLabel = 'No results found', | ||
| onValueChange, | ||
| readOnly = false, |
There was a problem hiding this comment.
leave empty as other components
| className, | ||
| customOptionRenderer, | ||
| defaultValue, | ||
| disabled = false, |
There was a problem hiding this comment.
leave empty as other components
| ...props | ||
| }, ref): JSX.Element => { | ||
| const [inputValue, setInputValue] = useState(''); | ||
| const [internalValue, setInternalValue] = useState<string[]>(defaultValue || []); |
There was a problem hiding this comment.
is it really mandatory to store the value? it should be available in the ark context already (see https://zagjs.com/components/react/combobox#machine-context)
No description provided.