Skip to content

AO3-7152 Change links in downloaded files to use HTTPS instead of HTTP #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

AO3-7152 Change links in downloaded files to use HTTPS instead of HTTP #5431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0658db
update renderer protocol
anmazz Oct 24, 2025
2aad9e4
update download steps to check for https
anmazz Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/download_writer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def write

def generate_html
renderer = ApplicationController.renderer.new(
http_host: ArchiveConfig.APP_HOST
http_host: ArchiveConfig.APP_HOST,
https: true
)
renderer.render(
template: "downloads/show",
Expand Down
4 changes: 2 additions & 2 deletions features/step_definitions/work_download_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
Then /^I should see the inspiring parent work link$/ do
parent = Work.find_by(title: "Worldbuilding")
inspired_link = "<a href=\"#{work_url(parent)}\">#{parent.title}</a>"
inspired_link = "<a href=\"#{UrlFormatter.new(work_url(parent)).with_https}\">#{parent.title}</a>"
page.body.should =~ /Inspired by #{Regexp.escape(inspired_link)}/m
end

Then /^I should see the external inspiring work link$/ do
parent = ExternalWork.find_by(title: "Example External")
inspired_link = "<a href=\"#{external_work_url(parent)}\">#{parent.title}</a>"
inspired_link = "<a href=\"#{UrlFormatter.new(external_work_url(parent)).with_https}\">#{parent.title}</a>"
page.body.should =~ /Inspired by #{Regexp.escape(inspired_link)}/m
end

Expand Down
Loading