AO3-7159 Fix/Show caution when accepting/rejecting co-creator requests with no selection #5418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
requested changes
Oct 24, 2025
Comment on lines
20
to
22
| selected_ids = Array.wrap(params[:selected]).reject(&:blank?) | ||
| if selected_ids.blank? | ||
| flash[:caution] = t(".must_select_request") |
There was a problem hiding this comment.
It would be simpler and less fragile to potential changes to always call @creatorships.where(id: params[:selected]) and decide whether to show the message based on the return value of that, instead of this extra Array check
There was a problem hiding this comment.
Thanks for your suggestions! They are helpful.
| end | ||
|
|
||
| context "without selecting any requests" do | ||
| it "displays an caution" do |
There was a problem hiding this comment.
Suggested change
| it "displays an caution" do | |
| it "displays a caution" do |
| it "displays an caution" do | ||
| fake_login_known_user(user) | ||
| put :update, params: { user_id: user.login } | ||
| expect(flash[:caution]).to eq("Please select at least one co-creator request first.") |
There was a problem hiding this comment.
Please use it_redirects_to_with_caution instead
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Yanpei-Wang
force-pushed
the
ao3-7159
branch
2 times, most recently
from
cca743e to
5391e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7159
Purpose
The purpose of this PR is to fix CreatorshipsController#update so that when users don’t select any Co-Creator Requests, a warning message is shown instead of an empty notice banner.
Credit
Yanpei Wang