-
Notifications
You must be signed in to change notification settings - Fork 629
AO3-4629 Fix positioning of Chapter Index and Download menus #5390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- With JS disabled, the chapter menu is not present (unchanged) and the download menu appears on its own row, after the other navigation. - With JS enabled, the menus are now position relative to their buttons so they never hide them. -- The download menu is the same width as its parent because the options are short. -- The chapter menu is allowed to be 100% the width of its parent.
…nce and use more specific selectors to avoid affecting other things in works/chapters
|
If it's the first gen iPhone SE, it's probably because it's a little bit narrower than the iPhone 12 mini. If it's a different version... yeah, beats me. Older OS, older browser, more weirdness? But in general, yeah, it's definitely something that can happen depending on the width of your screen, your font size, and maybe the length of the chapter title. (It happens with the chapter menu in the version that's on production, too.) It's preventable with the download menu if we switch from a horizontal list to a vertical one, but I found it was also harder to cause it with the download menu -- I really had to crank my font size up -- so I felt it was better to stick with the current horizontal design. I don't think it's particularly fixable on the chapter menu unless we start resizing and repositioning things with JavaScript or do a more radical reorganization of the buttons. I'd personally lean toward the second option, but in either case, I think this is probably enough of an improvement to be worth doing until then. |
|
Set this to ready to merge because I concur, this is an improvement over the current state. |

Issue
https://otwarchive.atlassian.net/browse/AO3-4629
Purpose
Fixes the positioning issues with the Chapter Index and Download menus on works by
I also
roleandaria-haspopupattributes because no ARIA is better than bad ARIA. I'll make a new issue (and pull request) to improve the accessibility of our accordions in the nearish future.We rarely chain our classes like
.work.navigation, but in this case, we really do only want this specific navigation, which is used in both.chapter-showand.work-show, so the Rails view classes didn't make a ton of sense as options either.Testing Instructions
Refer to Jira.