AO3-7002 Set up skin chooser skins in development #5354
Conversation
* Use File.exist? over removed File.exists? * Add rake tasks to reset_database.sh * Update README * Add support for parent_only skins through a subdirectory * Add support for /* MEDIA: */ and /* MEDIA: ENDMEDIA */ To reduce complexity, the following unused features are removed: * Remove support for /* REPLACE: */ * Remove support for multiple skin declarations using /* END SKIN */
| #end | ||
|
|
||
| unless !help_file.blank? && File.exists?("#{Rails.root}/public/#{help_file}") | ||
| unless help_file.present? && File.exist?("#{Rails.root}/public/#{help_file}") |
There was a problem hiding this comment.
This wasn't part of the issue, but I thought fixing the broken File.exists? here too would be helpful.
public/stylesheets/README.md
Outdated
| affect the skin on production! An admin will still need to edit the skin via | ||
| the admin interface and paste in the updated master version. | ||
|
|
||
| **Note**: To keep development data in sync with the master copies, please ensure any skin changes are mirrored in `site/user_skins_to_load`. |
There was a problem hiding this comment.
This isn't a good idea -- it's simply too easy for things to get out of sync. We need an approach where we will only have one copy of each skin and then load them into the database from there. It's okay if that means adding code comments to the master copies, renaming the files, and/or moving them to a different directory, as long as we also keep the subdirectory structure.
(I don't think we need to stick with the user_skins_to_load name, either. It's an unintuitive name that makes it sound like we're loading skins for individual users rather than loading the officially supported skins for the chooser.)
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
|
We discussed this a little and we'd like to take a different approach to this problem. Instead of putting information about the parents, media, and so on in the stylesheets and trying to parse it out with regular expressions, we'd like to move all of that information to the fixtures. Then the task can just be concerned with updating the skins' |
2 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-7002
Purpose
Rewrite and use
load_user_skinsload_official_skinsduring the initialization process./* MEDIA: */and/* MEDIA: ENDMEDIA */To reduce complexity, the following unused features are removed:
/* REPLACE: *//* END SKIN */This does not change production behavior.