Skip to content

Conversation

OlhaKissa
Copy link

vadim-ilchenko and others added 30 commits April 25, 2019 17:06
* add form value demo to explain why we need names in forms

* downgrade http-server version to solve windows issue

* do not add onSubmit listener by default
added backstopConfig module, change config file.
changed http-server to browsersync
updated according to linter
fix npm vulnerabilities(npm audit fix --force)
@OlhaKissa
Copy link
Author

DEMO LINK
TEST REPORT LINK

@OlhaKissa
Copy link
Author

DEMO LINK
TEST REPORT LINK

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-structured and semantically correct HTML form implementation that follows best practices for accessibility and user input validation. The use of

and elements appropriately groups related inputs, enhancing both readability and screen reader support. Required attributes are used correctly for mandatory fields such as name, surname, and agreement checkbox, which ensures the form collects essential data before submission. Each is clearly associated with its respective input, which improves usability. Additionally, input types are appropriately chosen (e.g., email, password, number, color, time, and range), making form validation and user experience more intuitive. However, there are minor improvements that can be made: the appears empty and may need a display label for clarity, and a typo exists in “Laba,” which might be intended as “Lada.” Overall, this form is functional, user-friendly, and ready for production with minimal refinement.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project demonstrates a well-structured and comprehensive HTML form, covering personal information, registration details, preferences, and additional feedback. The use of fieldset and legend tags helps organize the form semantically, making it easier to read and navigate. Input types are appropriately chosen for each field, including text, number, date, email, password, color, time, range, checkboxes, radio buttons, and select elements, which ensures a good user experience and proper data validation. The form also enforces basic constraints such as required fields, min/max values, and minlength/maxlength where applicable. One suggestion for improvement would be to enhance the accessibility and usability, for example by adding ARIA labels and placeholders consistently, and handling form validation feedback dynamically via JavaScript. Additionally, some options in the multi-select element appear empty or unclear, so refining those would improve clarity. Overall, this is a solid foundation for a fully functional and interactive registration form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.