-
Notifications
You must be signed in to change notification settings - Fork 12
Yaml and helper class #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml and helper class #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several typos in this. Nothing major, just a bunch of places where the documentation does not actually match the circuit we are building and the circuit in the images we're going to include. This would be confusing to readers, as the text description would not match the images.
That is, unless you plan to include different diagrams than the ones from the Sunfounder example that we built and tested out? Either way, please add and push the images as well.
There are also places where the included example commands don't match what is in the controller. We include these example commands in our documentation files as something for devs to try to run once they build our examples, using our example controllers, so it should match.
If these typos are the result of LLM output, please always TRIPLE-CHECK the output!
| import io.micronaut.http.annotation.Get; | ||
| import jakarta.inject.Inject; | ||
| import jakarta.inject.Named; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that to get the controller to show up in the AsciiDoc file, you need to surround the class with the "ex" tag--see other controller files for the exact syntax.
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deadline in Canvas is extended today because of the AWS outage that has taken Canvas down, so you still have time to get this merged and get full points for it. All that's left is the swapped image names and the linking of the controller code.
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Show resolved
Hide resolved
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/IRObstacleAvoidance.adoc
Show resolved
Hide resolved
Signed-off-by: Leandru Martin <[email protected]>
this pull request introduces two key updates that add support for an IR obstacle avoidance module.
A new helper class has been added ,
Features include :
YAML configuration updated to include pinout and parameters for the Ir obstacle avoidance module
where i looked for diagrams and pin information.