Sacrifice and GC Fix and Maybe Double Click Fix(?) #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshernoah
changed the title
|
@moshernoah @jackbelyeu looks like a valuable add. Are you still working this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
What was changed?
A Sacrifice button has been added to the Data Collection screen, that (should) work with threading. In addition, exiting the Group Config Screen after using AutoSort now correctly removes data from the Data Collection screen if it was used in AutoSort. Lastly, I believe I have fixed the changemeasurementdialogue to ensure that double clicking does not break
Why was it changed?
The button was added to meet client needs of being able to sacrifice live while scanning mice. The screen data fix was implemented as for researchers to correctly use the app, the updated Data Collection screen is a necessity.
The changes to ChangeMeasurementDialogue should make it such that it will not open another instance if one is open, removing the crashing issue from double clicking an animal on the screen.
How was it changed?
The same sacrifice_selected function from within map_rifd has been imported over, with changes so that it will stop threads if they are running, confirm the user wishes to remove the animal, and if yes then remove it. After a selection either way, yes or no, the program restarts the RFID reader if threads were running when it stopped them.