Use direct link to subdomain for the test assets

[d3flex]

Replace the `url_for with helper functions which return the domain name whenever this is applicable based on the setting.

• Link to domain for download assets like iso and Uploaded logs (includes also vars.json)
• No change in the redirection, assuming that this is out of scope here, and that in general it stays despite the direct link in the href.

issue: https://progress.opensuse.org/issues/189888

[Martchus]

Looks good so far :-)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.26%. Comparing base (a802d1d) to head (86a6c47).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6804   +/-   ##
=======================================
  Coverage   99.25%   99.26%           
=======================================
  Files         402      402           
  Lines       41363    41385   +22     
=======================================
+ Hits        41056    41079   +23     
+ Misses        307      306    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[okurz]

https://progress.opensuse.org/issues/189888 says "to simplify our implementation" but you add a net 21 lines and miss coverage. How does that match?

[perlpunk]

https://progress.opensuse.org/issues/189888 says "to simplify our implementation" but you add a net 21 lines and miss coverage. How does that match?

I think the simplification would be to remove the redirect, which is not part of the ticket for some reason

[okurz]

https://progress.opensuse.org/issues/189888 says "to simplify our implementation" but you add a net 21 lines and miss coverage. How does that match?

I think the simplification would be to remove the redirect, which is not part of the ticket for some reason

Then it still has to be part of the PR then :)

[Martchus]

And probably we even still need the redirect to support old links which might still be present/used on places we don't control.

So I don't think this can simplify this aspect for now but the PR as-is does improve efficiency.

[d3flex]

https://progress.opensuse.org/issues/189888 says "to simplify our implementation" but you add a net 21 lines and miss coverage. How does that match?

I think the simplification would be to remove the redirect, which is not part of the ticket for some reason

Then it still has to be part of the PR then :)

If it is decided to undo the redirect feature, I would rather do it in another PR

[perlpunk]

And probably we even still need the redirect to support old links which might still be present/used on places we don't control.

So I don't think this can simplify this aspect for now but the PR as-is does improve efficiency.

why do we need to redirect these links?
we just deliver the requested file under the regular domain, with the only difference that we make sure it is downloaded and not rendered. which is code which we already have in place in case there is no file domain configured

[Martchus]

we just deliver the requested file under the regular domain, with the only difference that we make sure it is downloaded and not rendered.

If we make sure it is downloaded then we can remove the redirection.