Skip to content

Fully cover WebAPI::Auth::OpenID #6773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fully cover WebAPI::Auth::OpenID #6773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/OpenQA/WebAPI/Auth/OpenID.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ sub auth_login ($c) {
);

my $claimed_id = $csr->claimed_identity($c->config->{openid}->{provider});
if (!defined $claimed_id) {
log_error("Claiming OpenID identity for URL '$url' failed: " . $csr->err);
return;
}
!defined $claimed_id and do { log_error("Claiming OpenID identity for URL '$url' failed: " . $csr->err); return; };
Copy link
Contributor

@perlpunk perlpunk Sep 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return will only return from the do block and not from the subroutine


$claimed_id->set_extension_args(
'http://openid.net/extensions/sreg/1.1',
{
Expand Down Expand Up @@ -59,8 +57,8 @@ sub auth_login ($c) {
return_to => $return_url,
trust_root => qq{$url/},
);
return (redirect => $check_url, error => 0) if $check_url;
return (error => $csr->err);
return (error => $csr->err) unless $check_url;
return (redirect => $check_url, error => 0);
}

sub _first_last_name ($ax) { join(' ', $ax->{'value.firstname'} // '', $ax->{'value.lastname'} // '') }
Expand Down Expand Up @@ -94,6 +92,7 @@ sub auth_response ($c) {
%params = map { $_ => URI::Escape::uri_unescape($params{$_}) } keys %params;

my $csr = Net::OpenID::Consumer->new(
# uncoverable statement
debug => sub (@args) { $c->app->log->debug('Net::OpenID::Consumer: ' . join(' ', @args)) },
ua => LWP::UserAgent->new,
required_root => $url,
Expand Down
Loading