Skip to content

Conversation

@okurz
Copy link
Member

@okurz okurz commented Sep 24, 2025

No description provided.

@okurz okurz force-pushed the feature/worker_key_secret branch from 7c02d07 to 7aa6b06 Compare September 24, 2025 10:43
@okurz okurz force-pushed the feature/worker_key_secret branch from 7aa6b06 to 76eecc1 Compare September 24, 2025 11:16
@okurz
Copy link
Member Author

okurz commented Sep 24, 2025

Changed to set the webui_host, not the host which is part of the specified webUI URL. Thx to @d3flex for pointing that out

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.25%. Comparing base (e5c0222) to head (76eecc1).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6767   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         402      402           
  Lines       41268    41269    +1     
=======================================
+ Hits        40961    40962    +1     
  Misses        307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? I'm asking because I'm wondering whether this covers the websocket connection as well. It likely does but it would be good to test that before merging.

@okurz
Copy link
Member Author

okurz commented Sep 25, 2025

Have you tested this? I'm asking because I'm wondering whether this covers the websocket connection as well. It likely does but it would be good to test that before merging.

I have tested that the settings are passed into the correct module but I have not covered the complete connection flow. I plan to do that. But also I might reconsider the place where the read the env variable because other env variables are also read in a different place. Maybe better if we put those together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants