dns/bind: Make builtin ACLs available #4926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the builtin ACLs (none, any. localhost and localnets) available
for selection:
1. Created new custom field types:
* AclField extending ArrayField
* AclModelRelationField extending ModelRelationField
* AclNetField extending NetworkField
2. Adds builtin ACLs as child nodes to ACL list via new AclField field type
3. Removes builtin name RegEx constraint from name field in Acl model
4. Ensures "any" and "none" builtins cannot be part of an ACL multi-select
via new AclModelRelationField field type
5. Ensures network validation is skipped for builtin ACLs via new AclNetField
field type
6. Updates the General and Domain models to use AclModelRelationField
7. Updates general.volt to:
* Disable command buttons for builtin ACLs
* Ensure the builtin ACLs are added to config.xml
8. Updates named.conf to exclude builtin ACLs from custom name list
9. Bumps model versions:
* Acl to v1.0.1
* General to v1.0.13
* Domain to v1.1.3
Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
force-pushed
the
bind-show-builtin-acls
branch
from
1007b74 to
3c6966f
Compare
|
Pushed two fixes:
This should be good to go... |
|
Here's a screen shot of the proposed ACLs tab for your consideration: 
CC: @fichtner @mimugmail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the builtin ACLs (none, any. localhost and localnets) available for selection: